Skip to content

Conversation

@bendk
Copy link
Contributor

@bendk bendk commented Nov 25, 2025

Removed what I hope are the last remaining tokio/hyper dependencies in our components:

  • Updated ads-client to use viaduct-dev for its integration tests.
  • Removed the unused backend-dev feature from viaduct.

Also improved the error handling on viaduct-dev. If you remove the
#[ignore] attribute from the ads-client integration tests, they now
correctly report that they're failing because they're trying to hit
HTTPS endpoints. I think you can re-enable these tests by configuring
them to hit http://ads.allizom.org instead of https.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@bendk bendk requested review from Almaju and mhammond November 25, 2025 17:19
@bendk bendk force-pushed the push-qvyvrkoqllrt branch from 0c44de7 to e1a663f Compare November 25, 2025 17:19
Removed what I hope are the last remaining `tokio`/`hyper` dependencies
in our components:
 - Updated `ads-client` to use `viaduct-dev` for its integration tests.
 - Removed the unused `backend-dev` feature from `viaduct`.

 Also improved the error handling on `viaduct-dev`.  If you remove the
 `#[ignore]` attribute from the ads-client integration tests, they now
 correctly report that they're failing because they're trying to hit
 HTTPS endpoints.  I think you can re-enable these tests by configuring
 them to hit `http://ads.allizom.org` instead of `https`.
@bendk bendk force-pushed the push-qvyvrkoqllrt branch from e1a663f to cb0c834 Compare November 25, 2025 18:00
Copy link
Member

@mhammond mhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bendk bendk added this pull request to the merge queue Nov 26, 2025
Merged via the queue into mozilla:main with commit b74205d Nov 26, 2025
14 checks passed
@bendk bendk deleted the push-qvyvrkoqllrt branch November 26, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants