Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed what I hope are the last remaining
tokio/hyperdependencies in our components:ads-clientto useviaduct-devfor its integration tests.backend-devfeature fromviaduct.Also improved the error handling on
viaduct-dev. If you remove the#[ignore]attribute from the ads-client integration tests, they nowcorrectly report that they're failing because they're trying to hit
HTTPS endpoints. I think you can re-enable these tests by configuring
them to hit
http://ads.allizom.orginstead ofhttps.Pull Request checklist
[ci full]to the PR title.